search

openstreetmap / trac-tickets

Archived Trac Tickets
1 stars 1 forks source link

Prevent duplicate posting on diary comments #2957

Closed openstreetmap-trac closed 3 years ago

openstreetmap-trac commented 3 years ago

Reporter: Andy Allan [Submitted to the original trac issue database at 3.21pm, Wednesday, 12th May 2010]

Loads of people post duplicate diary comments. I'm sure there will be a funky thing in rails to either prevent duplicate submissions, or we should just prevent people from posting the same text anyway

openstreetmap-trac commented 3 years ago

Author: JohnSmith [Added to the original trac issue at 4.50pm, Friday, 14th May 2010]

fixing duplicate diary entries would also be a good idea.

openstreetmap-trac commented 3 years ago

Author: amm [Added to the original trac issue at 5.01am, Sunday, 7th August 2011]

People continue to post duplicate diary entries and comments (e.g. http://www.openstreetmap.org/user/bigboss/diary ), so here is a quick patch to prevent such duplicates.

It simply looks at the last entry and compares it to the new entry. If it is identical, then it won't get added.

openstreetmap-trac commented 3 years ago

Author: TomH [Added to the original trac issue at 2.34pm, Sunday, 7th August 2011]

I took the radical approach of fixing the underlying problem that was causing errors that made people thing their diary entries hadn't posted.

Somehow that seems more sensible than pasting over the cracks.

openstreetmap-trac commented 3 years ago

Author: amm [Added to the original trac issue at 3.41pm, Sunday, 7th August 2011]

How do you fix that occasionally the servers respond slowly, or that someone might accidentally do a double click on the "save" button?

Although there might have been specific issues this time that have caused people frequently to post their diary entry multiple times, there will always be some reasons for people to press the save button more than once, as e.g. the age of this bug report shows. So I think it is still worth "pasting over those cracks" in addition to fixing any specific issues.

openstreetmap-trac commented 3 years ago

Author: TomH [Added to the original trac issue at 4.03pm, Sunday, 7th August 2011]

I understand the logic, but I'm reluctant to do anything which makes it less likely that people will report problems.

I didn't actually close the bug, so I am still considering it, but the patch looked like it would need some work and I didn't have time to go through it right now.

openstreetmap-trac commented 3 years ago

Author: mmd [Added to the original trac issue at 3.07pm, Thursday, 28th May 2020]

I believe this is less of an issue today. If there are duplicate diary posts or comments, they still can be hidden by an a moderator. Patch posted above wouldn't apply without some rework anyway.

Closing here. If this still an issue, please create a new issue on Github.