openstreetmap / trac-tickets

Archived Trac Tickets
1 stars 1 forks source link

Improve error-handling on map_features.xml #4283

Open openstreetmap-trac opened 3 years ago

openstreetmap-trac commented 3 years ago

Reporter: stevage [Submitted to the original trac issue database at 11.15pm, Friday, 9th March 2012]

I recently made a change to one of the map_features subsidiaries which had a typo in it, and received a couple of unhelpful error messages.

On loading:

TypeError: Error #1090: XML parser failure: element is malformed.

at net.systemeD.halcyon::NestedXMLLoader/fileLoaded()[I:\OSM\potgit6\potlatch2\net\systemeD\halcyon\NestedXMLLoader.as:39]

When trying to display the simple editor:

RangeError: Error #2006: The supplied index is out of bounds. at flash.display::DisplayObjectContainer/getChildAt() at mx.core::Container/getChildAt() at net.systemeD.potlatch2::CategorySelector/setSelectedFeature()[I:\OSM\potgit6\potlatch2\net\systemeD\potlatch2\CategorySelector.mxml:103] at net.systemeD.potlatch2::CategorySelector/__categoryStack_creationComplete()[I:\OSM\potgit6\potlatch2\net\systemeD\potlatch2\CategorySelector.mxml:12] at flash.events::EventDispatcher/dispatchEventFunction() at flash.events::EventDispatcher/dispatchEvent() at mx.core::UIComponent/dispatchEvent() at mx.core::UIComponent/set initialized() at mx.managers::LayoutManager/doPhasedInstantiation() at mx.managers::LayoutManager/doPhasedInstantiationCallback() at flash.utils::Timer/_timerDispatch() at flash.utils::Timer/tick()

Now, since we can consider the map_features to be user-modifiable (as opposed to something we just QA before checking in), we should give more helpful error messages if they mess it up.

openstreetmap-trac commented 3 years ago

Author: stevage [Added to the original trac issue at 4.42am, Saturday, 10th March 2012]

The actual typo that triggered the above was a missing close quote: <choice value="foo text="bar"/>