search

openstreetmap / trac-tickets

Archived Trac Tickets
1 stars 1 forks source link

When you move the map, P2 fails to fetch new OSSV Imagery #5482

Closed openstreetmap-trac closed 3 years ago

openstreetmap-trac commented 3 years ago

Reporter: SomeoneElse [Submitted to the original trac issue database at 9.31pm, Thursday, 4th January 2018]

To reproduce:

Run Firefox (I tried it on Ubuntu / KDE and on Windows 7)

Clear recent history in browser (to remove any caching effects)

Browse to e.g. https://www.openstreetmap.org/#map=19/52.58435/-2.77087

Edit the map (and login if required)

If the default background layer isn't set to OS OpenData StreetView, set it to that.

Note that the OSSV imagery loads OK

Drag the map so that a new bit of imagery is needed. That new bit of imagery does not load.

Whatever iD does to fetch imagery, it doesn't show the same issue.

openstreetmap-trac commented 3 years ago

Author: Richard [Added to the original trac issue at 12.37pm, Sunday, 14th January 2018]

Looking at the console, this appears to be Firefox being sniffy about the fact that OSSV is served over HTTP while P2 has been served over HTTPS. I guess this needs editor-imagery-index to be updated.

openstreetmap-trac commented 3 years ago

Author: SomeoneElse [Added to the original trac issue at 1.04pm, Sunday, 14th January 2018]

https://github.com/osmlab/editor-layer-index/pull/380

openstreetmap-trac commented 3 years ago

Author: SomeoneElse [Added to the original trac issue at 2.59pm, Tuesday, 16th January 2018]

https://github.com/osmlab/editor-layer-index/pull/380 has now been merged.

The problem seems ot occur with http sources that redirect to https. Some other sources at osm.org referred to in the editor-imagery-index redirect and some (as yet) do not. A bunch seem to be defined there but not actual exist or be usable, despite trying to fetch tiles in the right zoom range in the right are (e.g some OSM-hosted OS OOC maps). I suspect that many of these are dupicates of e.g. NLS maps.

There are three others - AGRI, Surrey Air Survey and one for the Philippines that show the issue. I can get the first 2 to load and show the same problem, and the fix for them is in here:

https://github.com/osmlab/editor-layer-index/pull/382

I can't get the Philippines imagery to load within P2 (but oddly can externally) so I haven't changed that one.

Presumably editor-layer-index is somehow either canned within P2 or is released only occasionally? The live version used by P2 hasn't been updated yet.

openstreetmap-trac commented 3 years ago

Author: Richard [Added to the original trac issue at 3.27pm, Tuesday, 16th January 2018]

It pulls it from http://osmlab.github.io/editor-layer-index/imagery.json . I think there might be some sort of build step that's required for that to be updated - not sure.

openstreetmap-trac commented 3 years ago

Author: TomH [Added to the original trac issue at 3.43pm, Tuesday, 16th January 2018]

Yes - somebody will need to run make and commit the built files.

openstreetmap-trac commented 3 years ago

Author: TomH [Added to the original trac issue at 3.48pm, Tuesday, 16th January 2018]

I've pushed a new build now.