openstudiocoalition / openstudio-sketchup-plugin

The OpenStudio SketchUp Plug-in is an extension to Trimble’s popular 3D modeling tool that adds OpenStudio context to the SketchUp program.
https://openstudiocoalition.org
Other
45 stars 10 forks source link

Model does not display in SketchUp #17

Open macumber opened 8 years ago

macumber commented 8 years ago

Model provided by @eringold (in issues repo) does not display in SketchUp when loaded. Double clicking spaces in the inspector causes the geometry to be shown. My guess is something is crashing silently when opening the file so that the sketchup entities are not created

macumber commented 8 years ago

@eringold have you seen this on any other models?

eringold commented 8 years ago

@macumber no, this was a completely new occurrence to me. Note: I was able to fix it by subdividing the large, >60-surface spaces into multiple smaller spaces.

macumber commented 8 years ago

How did you create this geometry in the first place? Did you import this model from gbXML or something other than creating it in SketchUp?

eringold commented 8 years ago

Nope, I traced over an imported dwg, then extruded with 'create spaces from diagram'.

jmarrec commented 8 years ago

I'm having the same issue right now. Model was displaying fine. I closed sketchup and reopened it and there's nothing displayed though I do see everything in the model inspector

jmarrec commented 8 years ago

If I change the version to 1.9.4 in text editor and try to open it in sketchup 2015 with OS 1.9.4 it doesn't work either.

I have many checkpoints so I pinpointed where it went wrong: right from the start. I had a functional model in 1.9.4, that I upgraded to 1.10.1. This works. Then my next checkpoint it already doesn't work.

Here's the changelog between the two:

I deleted in text editor all the generated info from the MidRise apartment (schedules, loads, constructions, rendering colors, etc) and now I can see the geometry in sketchup... Obviously this mean that my space types have been reset for these spaces, which is not something that I want.

Any idea?

jmarrec commented 8 years ago

I also tried deleting all spaces (3 plenums) with 50+ surfaces, and the model loads.

I also did the opposite: deleted all spaces except these three, and the model loads too...

I'm confused now.

jmarrec commented 8 years ago

The model with only the big plenums was loading. I split each plenum in two, now it won't load anymore. I thought maybe this had to do with the fact that it opened when I saved the model last from the API in command line, so I tried that too here, didn't work.

I emailed my model to you.

macumber commented 8 years ago

Added second file from @jmarrec

macumber commented 8 years ago

Somehow the space's SU entities are being deleted:

m = OpenStudio::Plugin.model_manager.model_interface.openstudio_model
s= m.getSpaces[0]
puts s.drawing_interface
  #<OpenStudio::Space:0x00000012f539c8>
puts s.drawing_interface.entity
   #<Deleted Entity:0x12a03680>
puts s.name
  Space 137
s.surfaces.each {|su| puts su.drawing_interface.entity}
  #<Deleted Entity:0x1433bee0>
  #<Deleted Entity:0x144c9fa0>
  #<Deleted Entity:0x144e2988> 
  #<Deleted Entity:0x144f9750>
  #<Deleted Entity:0x148ec6a0>
  #<Deleted Entity:0x1492afe0>
  #<Deleted Entity:0x14938848>

For the 1999.osm,

m.getSpaces.each {|space| s = space if space.nameString == "Space 130"}
puts s.drawing_interface.entity
  #<Deleted Entity:0x129a66b0>
- double click on space 130 in inspector and it shows up -
puts s.drawing_interface.entity
  #<Sketchup::Group:0x00000014296328>

Double clicking on the space in the inspector creates a new entity

macumber commented 8 years ago

Tested this occurs with OS 1.10 and SU 2016, OS 1.10 and SU 2015, OS 1.9 and SU 2014, OS 1.8 and SU 2014

macumber commented 8 years ago

http://forums.sketchup.com/t/groups-mysteriously-deleted-in-an-operation/19719/1

macumber commented 8 years ago

I spent a little more than a day looking at this and don't have any leads. Are you able to get around this issue by simplifying geometry when tracing over DXF?

jmarrec commented 8 years ago

For this specific building I spent a lot of time opening an earlier version that worked, getting the info I needed (surface name for example) and performing operations using the API, like setting adiabtic surfaces etc. After countless of them, the model started opening up in sketchup again...

I have no clue why but I was glad it did because I had windows and stuff to adjust or add, and I couldn't have done that in the dark, after 3-4 days of tinkering with it I was about to give up

Envoyé de mon iPhone

Le 2 févr. 2016 à 21:28, Dan Macumber notifications@github.com a écrit :

I spent a little more than a day looking at this and don't have any leads. Are you able to get around this issue by simplifying geometry when tracing over DXF?

— Reply to this email directly or view it on GitHub.

eringold commented 8 years ago

I was able to work around by simplifying geometry. I appreciate your investigative effort, @macumber!

jmarrec commented 8 years ago

yo tambien, +1

macumber commented 8 years ago

I may have to close this as won't fix

eringold commented 8 years ago

I won't object to that. I'll just think of this as a built-in reminder to not make overly complex models!

macumber commented 8 years ago

Hit this again on a model that I made, re-opening

File added 1999c.osm