search

openstyles / stylus

Stylus - Userstyles Manager
https://add0n.com/stylus.html
GNU General Public License v3.0
5.33k stars 300 forks source link

Options UI discoverability #34

Closed narcolepticinsomniac closed 7 years ago

narcolepticinsomniac commented 7 years ago

The new Options UI has a few cool new features, but much like the keyboard shortcuts, I think a lot of users may never realize they exist. Currently they're only accessible through the extensions page, or the right-click icon menu which has always just been a clumsier way to get to the Style Manager. It'd be a shame if they went unnoticed, so I decided to make a button for each in the popup and the Style Manager.

Figured I'd open an issue for any feedback.

narcolepticinsomniac commented 7 years ago

@schomery If you could take a look at this and determine if there's any issues/improvements, I think this would be a nice compliment to the features in the last release. If it's copacetic, I think it'd be good to get it out there. Not to mention, the icons are an improvement.

schomery commented 7 years ago

@narcolepticinsomniac how about having that "Manage installed styles" as a button as well? or maybe all of them as links.

narcolepticinsomniac commented 7 years ago

I wanted to make them buttons to draw attention to them, but you're right that leaving "Manage installed styles" as a link feels disjointed. I switched it to be a button as well. All of them being buttons is not only good to draw attention, but they're easier to read and click. Since two buttons are side by side, we're not really sacrificing much (if any) height either.

I also added a "Find editor styles" button to "More options" in the Style Manager. The ability to style the editor itself was introduced in the last big update almost a couple years ago, but I'm sure there's still quite a few users who haven't discovered the capability. There should've been something similar added at the time to introduce the new feature. The button simply opens a us.o Chrome editor styles search.

Since I've been mucking up the popup.html/manage.html files, I ran them through an organizer. I've tried to thoroughly test everything to make sure nothing got screwed up in the process, but everything seems fine. Fresh eyes never hurt though.

narcolepticinsomniac commented 7 years ago

Reopened because I wasn't even trying to close it just yet. Adding "fixes" must've closed it automatically? I thought that only occurred when directly followed by a reference, but I'm not very familiar.

Anyway, I double-checked the diffs and fixed a couple minor oversights. You can close it once you check it out, if you decide it's all good now @schomery .

schomery commented 7 years ago

Looks good to me! Thanks!