opensubtitles / service.subtitles.opensubtitles_by_opensubtitles

KODI OpenSubtitles.org addon modified by opensubtitles, works without login
https://forum.opensubtitles.org/viewtopic.php?f=8&p=36070
94 stars 37 forks source link

Opensubtitles addon does not work for Kodi Matrix #22

Open masca90021 opened 4 years ago

masca90021 commented 4 years ago

Hi guys,

Is there any updated file for Kodi Matrix ? I am in need of an update. Ty in advance,

Zero0Q commented 4 years ago

Same here, really needs one in Matrix

BramAlkema commented 4 years ago

See this for a temp workaround a fully ported python 3 version https://github.com/juokelis/service.subtitles.opensubtitles/tree/Matrix

zdzichu commented 4 years ago

Could @juokelis provide a PR with ported version here?

peno64 commented 3 years ago

@juokelis There are two unfortunate issues with your port (https://github.com/juokelis/service.subtitles.opensubtitles/tree/Matrix) First of all you did not start from this repo but from the original opensubtitles addon (https://github.com/opensubtitles/service.subtitles.opensubtitles) and secondly your port now only works with matrix. It would have been better to have the best of all in one addon...

juokelis commented 3 years ago

At the moment of porting both repos were abandoned. And for good reason - plugin was working properly on versions prior to Matrix. And another repo was the only one included in the official Kodi plugin project. So it was sole decision what to choose :) We could work together and put new code if there's some benefit for users there to the one submitted to Kodi.

peno64 commented 3 years ago

Well to be hounest, I don't use the opensubtitles addon anymore and not sure if I am interested to modify it. I use subloader (also doing opensubtitles but via a service (is being modified for modi 19 now, I already have a working version)) and a4ksubtitles. The latter is doing opensubtitles, podnadpsi, subscene, addic7ed and bsplayer all in one. Works very good and also already adapted for kodi 19. It works for both kodi 18 and 19.