fix: create new channel when needed

bytemain commented 3 months ago

Types

[x] 🐛 Bug Fixes

Background or solution

原来 Codeblitz 只默认创建了一对 Port，会导致创建多个 AppRenderer 时，还是复用这一个 Port，会导致功能错乱等。

ChangeLog

create channel when needed

Summary by CodeRabbit

新特性
- 引入了InMemoryMessageChannel，改善了应用内的消息处理能力。
- 通过依赖注入的方式，增强了CodeBlitzConnectionHelper和ServerApp类的连接管理灵活性。
- 导出了renderDiffViewer函数，提升了模块的功能性。
文档
- 新增了与差异查看器相关的类型，增强了模块的类型安全性和可读性。
修复
- 重新设计了连接建立逻辑，改进了性能与测试能力。

ant-codespaces[bot] commented 3 months ago

Run and Debug this pull request in Codespaces

coderabbitai[bot] commented 3 months ago

Walkthrough

## Walkthrough 此次更改引入了对 `ClientApp` 和 `CodeBlitzConnectionHelper` 类的核心依赖注入机制的增强，采用了 `InMemoryMessageChannel` 来改善消息处理和连接管理。通过更新连接逻辑及整合新接口，提升了代码的可维护性和可测试性。同时，通过对 `createChannel` 函数的重构，明确了通道的结构和类型，确保组件之间的交互更加清晰。 ## Changes | 文件路径 | 变更摘要 | |---------------------------------------|-------------------------------------------------------------------------------------------| | `.../src/client/index.ts` | 在 `ClientApp` 中新增依赖注入，使用 `InMemoryMessageChannel` 改进消息处理。 | | `.../src/client/override/webConnectionHelper.ts` | 在 `CodeBlitzConnectionHelper` 中添加 `InMemoryMessageChannel` 依赖，修改连接创建逻辑。 | | `.../src/connection/index.ts` | 重构 `createChannel` 函数，增加 `InMemoryMessageChannel` 接口，改进类型定义和结构。 | | `.../src/server/core/app.ts` | 在 `ServerApp` 中更新连接逻辑，使用 `InMemoryMessageChannel` 取代之前的 `ServerPort`。 | | `.../src/api/renderDiffViewer.tsx` | 新增导出 `IDiffViewerHandle`、`IDiffViewerProps`、`IDiffViewerTab`、`IExtendPartialEditEvent` 类型。 | | `.../src/index.ts` | 新增导出 `renderDiffViewer` 函数，增强模块功能。 |

Recent review details

**Configuration used: .coderabbit.yml** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 236a48aab59e2553f567c325612476f781dc1b65 and bbc2be6b6c51e607a1e406e6a964f01d29517832.

Files selected for processing (2)

* packages/core/src/api/renderDiffViewer.tsx (1 hunks) * packages/core/src/index.ts (1 hunks)

Files skipped from review due to trivial changes (1)

* packages/core/src/index.ts

Additional comments not posted (1)

packages/core/src/api/renderDiffViewer.tsx (1)
`17-22`: **导出语句看起来很好。** 这些导出语句确保了类型的可重用性和模块化。

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

opensumi / codeblitz