opensumi / codeblitz

Pure front-end IDE framework based on OpenSumi
https://codeblitz.opensumi.com
MIT License
187 stars 14 forks source link

fix: dispose plugin service will cause crash #115

Closed bytemain closed 3 months ago

bytemain commented 3 months ago

Types

Background or solution

CleanShot 2024-08-01 at 14 30 08@2x

卸载组件的时候会报错

ChangeLog

fix some crashes about dispose

Summary by CodeRabbit

ant-codespaces[bot] commented 3 months ago

Run and Debug this pull request in Codespaces

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough 此次更改聚焦于增强错误处理机制,主要通过引入新的工具函数 `tryCatchPromise` 来改进多个组件中的异步操作管理。文件中的直接调用被封装,以确保在处置过程中捕捉异常,从而提高了系统的稳定性和可靠性。此外,插件服务的处置流程也得到了明确化,整体上提升了应用的鲁棒性。 ## Changes | 文件路径 | 更改摘要 | |-----------------------------------|------------------------------------------------------| | `packages/core/src/api/createApp.tsx`
`packages/core/src/api/createEditor.tsx` | 用 `tryCatchPromise` 替代直接调用 `disposeAll()`,增强错误处理。 | | `packages/plugin/src/plugin.contribution.ts` | 在 `dispose` 方法中增加了对 `pluginService` 的检查,提升了稳健性。 | | `packages/plugin/src/plugin.service.ts` | 新增 `dispose()` 方法以明确插件服务的清理流程。 | | `packages/sumi-core/src/client/override/monacoOverride/contextKeyService.ts` | 移除 `super.dispose()` 调用,改变了处置逻辑。 | | `packages/sumi-core/src/common/util.ts` | 新增 `tryCatchPromise` 工具函数,改善异步操作的错误处理。 | | `packages/sumi-core/src/server/core/app.ts` | 在服务绑定和客户端通道处理函数中增强了错误处理和日志记录功能。 |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.