opensumi / core

🚀 A framework helps you quickly build AI Native IDE products. https://preview.opensumi.com
https://opensumi.com
MIT License
2.81k stars 354 forks source link

fix: dialog buttons cannot show #3803

Closed bytemain closed 3 weeks ago

bytemain commented 3 weeks ago

Types

Background or solution

在 codeblitz 上,必现 dialog buttons 出不来:

CleanShot 2024-06-24 at 17 00 09@2x

Changelog

fix dialog buttons cannot show

bytemain commented 3 weeks ago

/next

opensumi[bot] commented 3 weeks ago

🎉 PR Next publish successful!

3.1.3-next-1719220003.0

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.32%. Comparing base (43ba89b) to head (c3c9a14).

Files Patch % Lines
packages/overlay/src/browser/dialog.service.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## v3.1 #3803 +/- ## ========================================== + Coverage 55.16% 55.32% +0.15% ========================================== Files 1549 1540 -9 Lines 96094 93906 -2188 Branches 19948 19282 -666 ========================================== - Hits 53011 51949 -1062 + Misses 35658 34807 -851 + Partials 7425 7150 -275 ``` | [Flag](https://app.codecov.io/gh/opensumi/core/pull/3803/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi) | Coverage Δ | | |---|---|---| | [jsdom](https://app.codecov.io/gh/opensumi/core/pull/3803/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi) | `50.78% <0.00%> (+0.21%)` | :arrow_up: | | [node](https://app.codecov.io/gh/opensumi/core/pull/3803/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi) | `15.55% <0.00%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bytemain commented 3 weeks ago

CleanShot 2024-06-24 at 17 00 09@2x