fix: inline chat indent

Ricbet commented 1 month ago

Types

[x] 🐛 Bug Fixes

Background or solution

Changelog

修复 inline chat 的缩进问题

Summary by CodeRabbit

功能改进
- 更新了内容处理逻辑，现允许保留新内容的前导和尾随空格，从而影响差异的计算和显示。

railway-app[bot] commented 1 month ago

This PR was not deployed automatically as @Ricbet does not have access to the Railway project.

In order to get automatic PR deploys, please add @Ricbet to the project inside the project settings page.

coderabbitai[bot] commented 1 month ago

Walkthrough

修改涉及 InlineStreamDiffHandler 类的 recompute 方法，该方法现在直接设置 newContent 参数的值，而不再修剪字符串中的空格。这一变化允许在处理过程中包含前导和尾随空格，可能会影响差异的计算和显示。控制流程基本保持不变，但由于输入中的空格，输出结果可能会有所不同。

Changes

文件路径	更改摘要
packages/ai-native/src/browser/widget/inline-stream-diff/inline-stream-diff.handler.tsx	修改 `InlineStreamDiffHandler` 类的 `recompute` 方法，直接设置 `newContent` 的值，取消了空格修剪。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant InlineStreamDiffHandler
    participant VirtualModel

    User->>InlineStreamDiffHandler: 调用 recompute(newContent)
    InlineStreamDiffHandler->>VirtualModel: setValue(newContent)
    VirtualModel-->>InlineStreamDiffHandler: 更新完成
    InlineStreamDiffHandler-->>User: 返回计算结果

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 9bae65b59e2de83ce15a20853546a9c7750891d0 and 69f6b9d0581323e2b1452e5b9575bc53ec69d35d.

Files selected for processing (1)

* packages/ai-native/src/browser/widget/inline-stream-diff/inline-stream-diff.handler.tsx (1 hunks)

Additional comments not posted (1)

packages/ai-native/src/browser/widget/inline-stream-diff/inline-stream-diff.handler.tsx (1)
`434-434`: **验证空白处理的影响** `recompute` 方法现在直接设置 `newContent`，不再修剪空白。这可能会影响差异的计算和显示。请确保此更改不会引入任何意外的显示问题。请检查是否有测试覆盖此更改，确保在不同情况下的行为符合预期。

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.88%. Comparing base (9bae65b) to head (69f6b9d). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3961 +/- ## ========================================== - Coverage 54.89% 54.88% -0.01% ========================================== Files 1566 1566 Lines 95573 95573 Branches 19602 19594 -8 ========================================== - Hits 52461 52459 -2 - Misses 35794 35795 +1 - Partials 7318 7319 +1 ``` | [Flag](https://app.codecov.io/gh/opensumi/core/pull/3961/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi) | Coverage Δ | | |---|---|---| | [jsdom](https://app.codecov.io/gh/opensumi/core/pull/3961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi) | `50.35% <ø> (-0.01%)` | :arrow_down: | | [node](https://app.codecov.io/gh/opensumi/core/pull/3961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi) | `15.48% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensumi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opensumi / core