opensupplyhub / open-apparel-registry

An application for searching, matching, uploading factories.
MIT License
32 stars 13 forks source link

Data appearing in facility after a merge that was not visible before #1330

Open hlennett opened 3 years ago

hlennett commented 3 years ago

Overview

When merging two facilities, there is data that will sometimes appear in the facility profile after a merge, that was not visible before the merge.

Expected Behavior

The data that we see in facility profiles before a merge is the data that we can expect to see in the merged facility profile.

Actual Behavior

When looking at two facilities to be merged, the facility data (name & address) are almost identical. After a merge, new facility data shows up that does not match the data we saw before the merge.

Steps to Reproduce

This one is tricky to reproduce (although I have run into it 3 or four times now), because you only know it happened after a merge is complete and then it's hard to find another example. I did a screen record of running a few merges in hopes that one would produce the bug. You can see an example of the bug starting at minute 1:15 in the recording. The recording is too big to attach to this issue, but including a link to it.

Demo

https://drive.google.com/file/d/199haxxKRkX9kEnnLyNoAtL33nPO-fsPK/view?usp=sharing

Additional context

The times that I have run into this issue have all been with Soorty facilities (if you search Soorty as a facility name). There are a ton of these facilities in the OAR and the data is quite messy, so we have been doing a bunch of splitting and re-merging to clean it up (this is where we've been running into that split bug a lot). I'm wondering if because we've been doing all of that splitting and re-merging if there's some hidden historical data that's hanging on to some records? Although it's curious that it wouldn't always show up and only appears after a merge.

cc: @katieashaw @isaacokunato

mariel-oar commented 2 years ago

This happens from time to time, still an issue. It's not clear why it happens.