opensupplyhub / open-apparel-registry

An application for searching, matching, uploading factories.
MIT License
32 stars 13 forks source link

Add space between GPS coordinates and sentence about amending them #1526

Closed hlennett closed 2 years ago

hlennett commented 2 years ago

Overview

We have implemented a new feature that allows us to add a sentence after GPS coordinates that have been amended. Currently, that sentence comes directly after the GPS coordinates with no space or line break:

Screen Shot 2021-11-11 at 1 00 27 PM https://openapparel.org/facilities/CN2020070MPR4Z1?q=CN2020070MPR4Z1

Expected Behavior

We would like the amending sentence to start directly below the GPS coordinates (rather than immediately after them), to make it easier to read and digest.

TaiWilkin commented 2 years ago

Specific facilities where this is occurring can be found here: https://github.com/open-apparel-registry/open-apparel-registry-clients/issues/45 Having compared the rendered content between this and facilities we've tested locally, it seems that when the GPS coordinates are the canonical location data, they render in a span instead of a p, causing the warning to render inline with the coordinates. See here for exact code causing the issue.

hlennett commented 2 years ago

Formatting ok in this one: https://openapparel.org/facilities/CN2019310YD1N57?q=CN2019310YD1N57

But not this one: https://openapparel.org/facilities/CN2021188TE73PF?q=CN2021188TE73PF

As additional examples.

hlennett commented 2 years ago

@mariel-oar This was resolved with EP launch. Feel free to close.