search

opensupplyhub / open-apparel-registry

An application for searching, matching, uploading factories.
MIT License
32 stars 13 forks source link

Sector Field not in API Output #2287

Open KlausGPaul opened 1 year ago

KlausGPaul commented 1 year ago

Overview

When calling the /facilities GET endpoint e.g. via curl -X GET "https://openapparel.org/api/facilities/?page=1" -H "accept: application/json" ... the resulting JSON array contains no field "sector"

Expected Behavior

Field "sector" should be in the "properties" field of the return values.

Actual Behavior

The returned data structure is identical to the one in the openapparel version, without sector.

Steps to Reproduce

Additional context

At the sprintly check-in on 2023-02-15 @jwalgran proposed to @mariel-oar that since the list of sectors is already available on the search index, returning the full list of sectors with the facility search results should not add expense and be relatively straight forward to implement.

jwalgran commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @mstone121 @TaiWilkin