search

opensupporter / osdi-docs

OSDI Specification
opensupporter.org
Other
86 stars 47 forks source link

feat(triggers): adds types of autoresponders #294

Closed robertsonsamuel closed 7 years ago

robertsonsamuel commented 7 years ago

Pull request for enhancement for different types of autoresponders via #292.

j-ro commented 7 years ago

This looks good! I'd say we may need a bit more explanation on what identifiers are in this case, since they're a bit different from our normal ones. Basically just saying this identifies a specific autoresponse on the server, and how those identifiers are constructed is server behavior rather than spec, since autoresponses aren't their own API resources.

We also probably want to add this partial to the person signup helper too.

robertsonsamuel commented 7 years ago

Makes sense, I'll update the pull request with those changes. 👍

robertsonsamuel commented 7 years ago

This is already on the person signup helper ? Do you mean include this partial on the People resource ?

j-ro commented 7 years ago

Ah, it is indeed, my mistake, no need to add then, just the update to wording.

robertsonsamuel commented 7 years ago

Perfect. Thank you!

joshco commented 7 years ago

Approved by committee 8/31