add share_url to share_options items specific to service (e.g. facebook, twitter, etc)

[schuyler1d]

Both because twitter benefits from short urls, and because a system may want to track sharing on different platforms separately, share_url may differ by the context.

I tihnk it's acceptable for implementations to use only the root share_url but for those that are share_option-aware, it would be good to standardize an option.

[joshco]

lets talk it through on today's call!

[j-ro]

Wouldn't typically you put the link you're sharing in twitter directly in the text? Same with email? But Facebook makes sense I suppose, since that's a separate field.

[schuyler1d]

@j-ro Yes, it will often be in the text, but for various purposes, a system (backend or frontend) may need the pure url:

• If someone composes their own tweet.
• The record is being served to the creator/editor of the petition, and the custom tweet is not yet made
• For tracking purposes (i.e. what url to track this petition with from analytics sources)
• The documentation already mentions that the text can be a template which has a place for the url

As you say, for facebook, it's a separate field.

[joshco]

@jimshare Jim can you weigh in here? we want to hear what shareprogress has to say before we move forward!

[jimshare]

Agree with @schuyler1d here -- sometimes people may put their link directly in the Twitter text, but it's often appended separately (Twitter in fact now uses a separate share parameter for link, rather than asking people to encode it directly in the Twitter message). And we do use separate links (some shortened, some not) for sharing through the ShareProgress toolbox, so it does differ by share method.

[joshco]

Looking good, PLEASE REVIEW, proposal to be approved in Jan

[j-ro]

looks good here from a quick review today!