opensupporter / osdi-docs

OSDI Specification
opensupporter.org
Other
86 stars 47 forks source link

helper action functions: Improper use of "improper subset" #304

Closed mpaquette1 closed 6 years ago

mpaquette1 commented 6 years ago

in _includes/helper_action_functions.md, Question Responses are described like so:

name type description
responses string[] One or more responses to the Question, if the corresponding question_type is SingleChoice or MultiChoice; should be an improper subset of the responses available for the question.

An improper subset is identical to the set of which it is a subset. So, if I read this correctly, it says that the array of answers submitted with (e.g.,) the Person Signup Helper should include ALL possible responses, not just the responses chosen by the person.

Assuming we actually want the person's responses, and not the set of all possible responses, the word "improper" should be removed.