opensuspect / opensuspect-legacy

OpenSuspect is an open source social deduction game, similar to Mafia or Among Us.
https://opensuspect.com
GNU General Public License v3.0
180 stars 30 forks source link

Items and inventory based on #254 #279

Closed nicemicro closed 3 years ago

nicemicro commented 3 years ago

It has been a long time since #254 has been PR'd, so I tried to merge the main branch into it, so we can proceed.

github-actions[bot] commented 3 years ago

HOW TO REVIEW:

zapzoop0099 commented 3 years ago

The game is acutally working fine and debug messages are also nice. But i have found a loophole in the system pretty easy to be fixed but important.Actually using this loophole player can pick up or to be more precise drag 2 items in one place. How to reproduce:-

Using this a player can easily drag two items at once place.This was also present in the Base PR. It can be easily fixed by changing the rate at which the player can pick up item

nicemicro commented 3 years ago

Multiple things are addressed, including @zapzoop0099 's concerns for the abusability of repeated dast pick up and drop of items. The item highlighting has been revamped, now the item you can pick up with the "E" key is highlighted in green, others that you can select by the mouse are highlighted in yellow.

nicemicro commented 3 years ago

apart from the merge conflict, the infiltrator can kill, pick up an item, reload(while holding the item), and kill again(while holding the item)

Thanks for the in depth testing, guess this will require a little more in-depth rewrite of some parts, I'll get be back to it as soon as possible.