opensvc / multipath-tools

Other
59 stars 47 forks source link

Q4/2021 multipath-tools update #20

Closed mwilck closed 2 years ago

mwilck commented 2 years ago

Hello Christophe,

here is the next PR. Breakdown of important changes:

@xosevp: multiple hardware table and man page fixes

@lucab: multipathd.socket: add missing conditions from service unit (closes #16, closes #15)

@lixiaokeng: persistent reservation fixes

@bmarzins:

@mwilck:

Notes on the new github workflows

The coverity workflow runs only on the coverity branch. It requires creating repository secrets to be run:

Without these properly set, the workflow will fail.

The ABI checking workflow has two modes:

  1. On the branch named by the secret ABI_BRANCH (default: "master"), it creates the reference ABI. This succeeds always. The ABI representation in XML format will be saved in a github workflow artifact.
  2. Other branches will be compared to the reference ABI, and the workflow will fail if differences are detected. Both the ABI and the output of the abidiff command will be saved as artifacts. Failure shouldn't be considered fatal in particular on PRs, but if a PR is merged for which the ABI check fails, the library versions must be bumped in the patch set as appropriate.

~@bmarzins, you'll note that I pushed 3 workflow-related fixes without sending them to the mailing list for review. I suppose this is alright. Bugs in workflows tend to surface very quickly.~

mwilck commented 2 years ago

I've added some patches from @xosevp which I'd miss first-time around. Also, the not-yet-reviewed patch for multipathd.service which I just submitted to dm-devel.

mwilck commented 2 years ago

I apologize.

I had to rebase because 2 patches early in the series had been missing "Reviewed-by:" tags. Also, I decided to move my ABI and workflow related patches up to the top and submit them to dm-devel. I did this because I improved the ABI handling once more (less false positives) and added some tidy-up for libmultipath.version according to the late discussion between @bmarzins and myself.

mwilck commented 2 years ago

I pushed once more to add the missing Reviewed-by: tags from Ben for the "last minute" patches.