search

opensvc / multipath-tools

Other
60 stars 48 forks source link

Add missing include <assert.h> #25

Closed Uglymotha closed 2 years ago

Uglymotha commented 2 years ago

checkers.c: In function 'start_checker_thread': checkers.c:392:9: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration] 392 | assert(ctx && ctx->cls && ctx->cls->thread); | ^~ checkers.c:13:1: note: 'assert' is defined in header ''; did you forget to '#include '?

xosevp commented 2 years ago

Patches should be posted to dm-devel list, see README.

mwilck commented 2 years ago

Well this is simple enough to be merged without going through the mailing list, I suppose. But we still won't be using a PR workflow.

@Uglymotha, please add a Signed-off-by line.

mwilck commented 2 years ago

When the s-o-b is added, I'll push this to https://github.com/openSUSE/multipath-tools/tree/queue and include it into the next PR here.

(on those systems where I was testing, assert.h is implicitly included via the liburcu headers. But that's bad style, so I agree it should be added explicitly).

mwilck commented 2 years ago

@Uglymotha, our policy is to add an s-o-b to every commit. If you can't provide an updated patch, I'll recreate your patch with my s-o-b, giving you credit with a Reported-by: tag. Anyway, I'll wait a few more days.

Uglymotha commented 2 years ago

Hi,

Apologies for the late reaction, I was on vacation last week. Commit message has been amended with signed-off-by.

-Sietse

From: Martin Wilck @.> Sent: Thursday, 17 February 2022 17:46 To: opensvc/multipath-tools @.> Cc: Sietse van Zanen @.>; Mention @.> Subject: Re: [opensvc/multipath-tools] Add missing include (PR #25)

@Uglymothahttps://github.com/Uglymotha, our policy is to add an s-o-b to every commit. If you can't provide an updated patch, I'll recreate your patch with my s-o-b, giving you credit with a Reported-by: tag. Anyway, I'll wait a few more days.

— Reply to this email directly, view it on GitHubhttps://github.com/opensvc/multipath-tools/pull/25#issuecomment-1043171776, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC3S6AMMLVNXDVTMHOJ7KKLU3UQ4BANCNFSM5LQJMREA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.**@.>>