multipath: display the correct configuration when dumpping config

opensvc / multipath-tools

Other

60 stars 48 forks source link

multipath: display the correct configuration when dumpping config #88

Closed Cav4ever closed 3 months ago

Cav4ever commented 5 months ago

"multipath -t" and "multipath -T" might show the wrong multipathd configuration items "retrigger_tries" and "force_sync". Make sure they don't.

I've already sent this patch to the mailing list for multipath-tools(dm-devel@lists.linux.dev). https://lore.kernel.org/dm-devel/tencent_FE02DEB8FF48DD9EE156F288BCE172E25709@qq.com

mwilck commented 5 months ago

This doesn't make sense. The changes affect only multipath's internal conf variable, which is never written back, and ceases to exist when multipath terminates.

Cav4ever commented 5 months ago

This doesn't make sense. The changes affect only multipath's internal conf variable, which is never written back, and ceases to exist when multipath terminates.

@mwilck My previous description was a bit ambiguous, so I'll describe it more clearly now. "multipath -t" and "multipath -T" are used to dump multipathd configurations. But now, "multipath -t" and "multipath -T" might show the wrong multipathd configuration items "retrigger_tries" and "force_sync". Make sure they don't.

Cav4ever commented 4 months ago

@mwilck
I see this patch has beeen taged with "Reviewed-by" by Benjamin Marzinski. https://lore.kernel.org/dm-devel/ZnmY-Mu2hcmU_4Qm@redhat.com/ Will you commit this patch to openSUSE/multipath-tools sometime in the future?

Cav4ever commented 3 months ago

@mwilck I have noticed your review record on the mailing list for multipath-tools.
Thanks for your review and revised opinion. I haved sent the updated patch to the mailing list: https://lore.kernel.org/dm-devel/tencent_C349DF9EE757FA8936E17CE2F90388B8B909@qq.com/

The patch on github has also been synchronized with the changes.

mwilck commented 3 months ago

Thanks! I've applied this to https://github.com/openSUSE/multipath-tools/commits/queue/.

(I've taken the liberty to correct the typo "dumpping" while applying)

Cav4ever commented 3 months ago

Thanks! I've applied this to https://github.com/openSUSE/multipath-tools/commits/queue/.

(I've taken the liberty to correct the typo "dumpping" while applying)

Thanks for fixing my spelling mistake.