opensvc / multipath-tools

Other
60 stars 48 forks source link

Add after=systemd-tmpfiles-setup.service #97

Closed foolstrong closed 2 months ago

foolstrong commented 2 months ago

In some case, multipath-tools is build base on runtimedir=/var/run, but run in environment that /var/run is symlink to /run, add after=systemd-tmpfiles-setup.service ensure that the /var/run symlink created already when the service is started.

fix #95

github-actions[bot] commented 2 months ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

tmpfiles

Previously acknowledged words that are now absent sdc 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:foolstrong/multipath-tools.git](https://github.com/foolstrong/multipath-tools.git) repository on the `master` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/opensvc/multipath-tools/actions/runs/10767704022/attempts/1' ```
Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (255) from .github/actions/spelling/expect.txt and **unrecognized words** (1) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|13|3| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|14|2| [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|10|1| [cspell:golang/dict/go.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/golang/dict/go.txt)|2099|7|1| [cspell:k8s/dict/k8s.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/k8s/dict/k8s.txt)|153|6|1| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:php/dict/php.txt cspell:node/dict/node.txt cspell:python/src/python/python-lib.txt cspell:golang/dict/go.txt cspell:k8s/dict/k8s.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
github-actions[bot] commented 2 months ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

tmpfiles

Previously acknowledged words that are now absent sdc 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:foolstrong/multipath-tools.git](https://github.com/foolstrong/multipath-tools.git) repository on the `master` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/opensvc/multipath-tools/actions/runs/10767889268/attempts/1' ```
Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (255) from .github/actions/spelling/expect.txt and **unrecognized words** (1) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|13|3| [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|14|2| [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|10|1| [cspell:golang/dict/go.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/golang/dict/go.txt)|2099|7|1| [cspell:k8s/dict/k8s.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/k8s/dict/k8s.txt)|153|6|1| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:php/dict/php.txt cspell:node/dict/node.txt cspell:python/src/python/python-lib.txt cspell:golang/dict/go.txt cspell:k8s/dict/k8s.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
mwilck commented 2 months ago

This is wrong. systemd-tmpfiles-setup.service starts After=local-fs.target, which introduces an ordering cycle, as multipathd.service starts before local-fs-pre.target.

That said, we do have a problem here, because multipathd requires that /run/multipath exists, and we currently rely on systemd-tmpfiles-setup.service to create it for us. But this problem needs to be fixed be other means.

Cc: @bmarzins

mwilck commented 2 months ago

Sorry I was confused here because multiple PRs have been opened. @foolstrong why didn't you just update this PR? Anyway, please forget this and see #98.