search

openswoole / protoc-gen-openswoole-grpc

Open Swoole GRPC Compiler
https://openswoole.com/docs/modules/grpc-compiler
MIT License
5 stars 2 forks source link

Example code used in generated PHP output #2

Closed AndrewCustomSumIT closed 2 years ago

AndrewCustomSumIT commented 2 years ago

This line generates source code that contains a reference to the HelloReply example, set as the return type on the _getNext method.

https://github.com/openswoole/protoc-gen-openswoole-grpc/blob/5d71d92ceb4bd0e4b8ddd37bb74ba257dd390115/php/clienttpl.go#L69

I'm thinking it should be {{ name $ns $m.OutputType }}.

andrejro2 commented 2 years ago

There are 2 issues with this method. I created a fix for that, PR is waiting for author's approval here: https://github.com/openswoole/protoc-gen-openswoole-grpc/pull/3

doubaokun commented 2 years ago

Thanks for the contribution!