search

opentable / design-tokens

A place where OpenTable engineers and designers openly work together
https://opentable.github.io/design-tokens/
MIT License
80 stars 74 forks source link

[LOL-1644] Credit card icons added #517

Closed ricalebro closed 3 years ago

ricalebro commented 3 years ago

This PR adds credit card icons for the Wallet work: https://www.figma.com/file/4PQp6K9dZPnkiUCW4GbpiN/Wallet%E2%80%94Web?node-id=336%3A2381

ronniechong commented 3 years ago

The PR is failing because the icons are expected to be 24 x 24. These icons are 40 x 24. Are these OTKit icons?

char1e5 commented 3 years ago

@ricalebro I could not find credit card icons in otkit icons library. Could you please confirm with designers to add this into otkit? cc @rmorabia

ricalebro commented 3 years ago

@ricalebro I could not find credit card icons in otkit icons library. Could you please confirm with designers to add this into otkit? cc @rmorabia

I'm talking to design at the moment about where these should live, as they don't match the 24x24px design of the others, which is a requirement in the build right now.

char1e5 commented 3 years ago

@ricalebro I got confirmation from design on this today. They don't want to have non-standard icons in otkit tokens. We can just add them in CFE to share across components.

ricalebro commented 3 years ago

Closing this as the icons will live in the cfe instead, see https://github.com/opentable/consumer-frontend/pull/4069