search

opentable / otj-server

OpenTable Java server template component
Apache License 2.0
1 stars 16 forks source link

OTPL-3592 OTJ Reactive Server module #93

Closed scottjohnson closed 5 years ago

scottjohnson commented 5 years ago

Introduces @ReactiveServer annotation to configure a service using the new top-level otj-server-reactive module.

Unit tests are by-and-large replicated from otj-server-mvc to validate the same functionality works in the same way as it was previously tested, with the exception that test requests are issued with WebTestClient instead of TestRestTemplate, responses come in the form of Mono, and the internal echo client replaces RestTemplate with WebClient to be reactive all up and and down the test stack.

scottjohnson commented 5 years ago

Very nice! You might want to mark the old annotations as deprecated and add JavaDoc pointing them to the new ones.

@adamzr, @mikebell90 had suggested deleting the old annotations (which I did in this PR). I could go either way.

scottjohnson commented 5 years ago

Some of the tests are a bit flakey for a variety of reasons that I think come from library stuff. I'm debating how to handle that.