Attribute Id should not be required when updating an attribute value using id

opentdf / platform

Persistent data centric security that extends owner control wherever data travels

BSD 3-Clause Clear License

18 stars 10 forks source link

Attribute Id should not be required when updating an attribute value using id #129

Closed jrschumacher closed 7 months ago

jrschumacher commented 9 months ago

When updating an attribute value it is prompting for the attribute id, but the value id is provided.

go run main.go policy attributes values update --id 5963b20e-0932-405a-88e4-6171870edbd5 --value tt2
 ERROR    : rpc error: code = InvalidArgument desc = validation error:
           - attribute_id: value is required [required]

jrschumacher commented 7 months ago

@jakedoublev could you validate that this was corrected?

jakedoublev commented 7 months ago

Confirmed: https://github.com/opentdf/platform/blob/main/services/policy/attributes/attributes.proto#L186C9-L186C36

jakedoublev commented 7 months ago

Fixed