Authorization service is logging the subject mappings during an AccessPDP check

opentdf / platform

OpenTDF Platform monorepo enabling the development and integration of _forever control_ of data into new and existing applications. The concept of forever control stems from an increasingly common concept known as zero trust.

BSD 3-Clause Clear License

17 stars 5 forks source link

Authorization service is logging the subject mappings during an AccessPDP check #1503

Open jrschumacher opened 1 week ago

jrschumacher commented 1 week ago

There is somewhere in the code that is logging all subject mappings when log level is set to debug. Debug log level should still be performant even when debugging an issue. With the log being so large, this could potentially decrease performance as subject mappings are added.

Find in the code where this log statement is taking place and remove it or change it to trace level log.

Acceptance Criteria:

Remove the excessive logging of subject mappings

elizabethhealy commented 1 week ago

some places where the logs are big https://github.com/opentdf/platform/blob/144aeda9141123cbfad44271844df49d632744f2/service/internal/access/pdp.go#L56 https://github.com/opentdf/platform/blob/144aeda9141123cbfad44271844df49d632744f2/service/internal/access/pdp.go#L267

strantalis commented 1 week ago

Also https://github.com/opentdf/platform/blob/144aeda9141123cbfad44271844df49d632744f2/service/internal/access/pdp.go#L568-L571