opentdf / web-sdk

OpenTDF JavaScript SDK
BSD 3-Clause Clear License
0 stars 1 forks source link

fix: Changes to make regex patterns more efficient, accurate and simpler #376

Closed jentfoo closed 3 weeks ago

jentfoo commented 3 weeks ago

This PR contains changes to address regex issues discovered by CodeQL:

Changes (see also commit messages):

After discussing with @dmihalcik-virtru we decided to further simplify WWW_HOST pattern. We are able to remove the www and negative www check, remove the group capturing, and simplify the subdomain pattern. Overall this notably improves the performance and understanding of this pattern.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dmihalcik-virtru commented 3 weeks ago

sorry approved in wrong profile