openteamsinc / closember

https://closember.org
BSD 3-Clause "New" or "Revised" License
64 stars 5 forks source link

Fix code typo and disable workflow on cron trigger in forks #25

Closed bskinn closed 1 year ago

bskinn commented 1 year ago

Deploy step only to occur on main branch, and on the openteamsinc repo. (NOTE: This has been changed, see below.)

Also update workflow to the current checkout action version.

Also fix a code typo that was breaking the workflow. (Unclear to me if execution reaching the code path where the typo was present means that something serious is going wrong with the queries.)

bskinn commented 1 year ago

Ok, wait -- is the live site getting deployed by the deploy step in this workflow?

Or by a separate github-pages deployment environment?

Or are both pieces important?

bskinn commented 1 year ago

<looks closer>

Looks like both pieces are important? The workflow step converts the built site into a Github Pages format in the gh-pages branch, and then Github Pages twigs off of that branch to actually publish to live?

bskinn commented 1 year ago

Oh, right -- cron trigger only runs on default branch, so that's redundant.

I still would like the filter to only run on the openteamsinc repo -- I don't need a regular build onto a gh-pages branch in my fork.

bskinn commented 1 year ago

Ok, changed my mind. We want to skip the entire workflow if the trigger is cronjob and the repo is anything other than openteamsinc/closember. Otherwise, we're making forks noisy, and wasting API calls.

Carreau commented 1 year ago

Thanks ! SorryI'm just back from CampQuansight.

bskinn commented 1 year ago

No worries, thanks! Not urgent.