search

opentechinstitute / commotion-feed

Feed of Commotion components to be pulled in by OpenWRT
GNU Affero General Public License v3.0
4 stars 11 forks source link

Update luci-commotion requirements to include freifunk p2pblock #35

Closed seamustuohy closed 10 years ago

seamustuohy commented 11 years ago

per: https://github.com/opentechinstitute/luci-commotion/issues/97

areynold commented 11 years ago

Easy enough. Can this be handled as a regular pull request instead of putting it in the Usability stream? Since it will require a config update to commotion-openwrt I worry that we will end up with conflicts by the time usability gets merged.

areynold commented 11 years ago

Done. See https://github.com/opentechinstitute/commotion-openwrt/tree/ff-p2pblock and https://github.com/opentechinstitute/commotion-feed/tree/ff-p2pblock.

@elationfoundation, you mentioned some settings tweaks and that @jheretic had requested additional testing. What else should be rolled into the pull request?

westbywest commented 11 years ago

The freifunk-p2pblock script, as packaged into OpenWRT, assumes the presence of an interface named 'wan' to apply all of its iptables rules to. If no active wan interface exists, e.g. on repeater nodes with the present Commotion-OpenWRT firewall, then freifunk-p2pblock will have no effect.

glamrock commented 10 years ago

Are we going to expand on the upstream freifunk-p2pblock script for v1.1?

jheretic commented 10 years ago

The wan interface has since been added, though freifunk-p2pblock has not been added in pending further QoS work. So an external install of freifunk-p2pblock should at least function as expected, though it is as yet unsupported. I'm closing out this issue as finished.