MDP fixes - Githubissues

opentechinstitute / commotiond

The system management daemon for the Commotion Wireless Project.

https://commotionwireless.net

GNU Affero General Public License v3.0

26 stars 21 forks source link

MDP fixes #68

Closed hawkinswnaf closed 10 years ago

hawkinswnaf commented 10 years ago

Fixes discovered when testing mdp.

areynold commented 10 years ago

Appears to be meshing. @dismantl: questions from the email thread.

test that two nodes can mesh using signed routes
latest Setup Wizard code generates the proper config information and generates good keys. The only problem is that the mdp-init command expects a file path and not a directory path. This means that we might have to change the value of the servalpath generated by SW. Just something to keep an eye out for.
may go against the spirit of mdp-sign. I now realize that @dismantl did mean for the function to return the entire contents of the message + its signature. Unfortunately the olsrd MDP plugin was not expecting that -- it expected only the signature in the response. I'm sorry for misunderstanding and will not be offended if you reject my change and prefer to make the appropriate revisions to the caller (olsrd mdp).

dismantl commented 10 years ago

I'm pretty sure I meant the command to return just the signature. Does it not do that?

hawkinswnaf commented 10 years ago

It does now :-)

On Sunday, December 22, 2013 12:11 EST, Dan Staples notifications@github.com wrote:

I'm pretty sure I meant the command to return just the signature. Does it not do that?

Reply to this email directly or view it on GitHub: https://github.com/opentechinstitute/commotiond/pull/68#issuecomment-31091310

hawkinswnaf commented 10 years ago

And this is consistent with the way that the olsrd mdp plugin is written -- the plugin expects that only the signature is returned. So, as long as you are okay with mdp-sign returning only the signature, then this pull request should be good to go!

On Sunday, December 22, 2013 12:11 EST, Dan Staples notifications@github.com wrote:

I'm pretty sure I meant the command to return just the signature. Does it not do that?

Reply to this email directly or view it on GitHub: https://github.com/opentechinstitute/commotiond/pull/68#issuecomment-31091310

areynold commented 10 years ago

I'm a moron. I forgot I built my first couple of images using your fork and built later images without your fixes. That probably explains a lot of the commotion-service-manager bugs I've seen today.

hawkinswnaf commented 10 years ago

Rebuild!! Good things may happen ;-)

On Sunday, December 22, 2013 14:14 EST, areynold notifications@github.com wrote:

I'm a moron. I forgot I built my first couple of images using your fork and built later images without your fixes. That probably explains a lot of the commotion-service-manager bugs I've seen today.

Reply to this email directly or view it on GitHub: https://github.com/opentechinstitute/commotiond/pull/68#issuecomment-31093689

areynold commented 10 years ago

Looks like that was it!