opentechinstitute / luci-commotion

Commotion configuration pages for the LuCI web interface
GNU General Public License v3.0
11 stars 17 forks source link

Additional network interfaces announce vs. mesh #127

Open seamustuohy opened 10 years ago

seamustuohy commented 10 years ago

The additional network interfaces page currently does not have dependencies between flags as requested. It seems that Flags do not have the ability to be dependencies. I will add this functionality after R1.1

dismantl commented 9 years ago

@elationfoundation, can you explain this a little more?

seamustuohy commented 9 years ago

My Bad, should have properly linked this to the surrounding issues.

From Issue 43

meshabilty: whether to pass mesh routing traffic over this interface announceability: whether to declare this interface's subnet to the rest of the mesh (via, for instance, an HNA) ... The first two parameters should exclusive (you shouldn't be able to mesh over a client network)."

The overarching flag issue is described in greater detail in issue 133. It all is derived from the original specification in issue 85.

If I remember correctly, and it has been a little over a year. The core issue was that flags don't have a string that depends can check. BUT! I figured out later that CBI checks on flags check for the self.enabled value if true and and empty string if false. This only applies to flags. So, the above functionality should be implementable with that known. let me know if I am mistaken.