search

opentechinstitute / luci-commotion

Commotion configuration pages for the LuCI web interface
GNU General Public License v3.0
11 stars 17 forks source link

[CLOSED] fixed some bugs with app icons; removed extraneous files #358

Closed oti-tech closed 10 years ago

oti-tech commented 10 years ago

Issue by dismantl Monday Dec 09, 2013 at 19:25 GMT Originally opened as https://github.com/opentechinstitute/luci-commotion-apps/pull/40

this fixes a few things:

  1. the default app icons were SVGs, which don't render in some older browsers (notably <= IE 8). This changes them to PNGs.
  2. the icons in the picker would be highlighted black when hovered over, which would make them totally black due to icon transparency. This changes the highlight color to a light pink in line with our color scheme.
  3. 'http://' and the 'thisnode' alias were prepended to each app icon path unnecessarily. This removes that, and has the benefit of not breaking if we decided to change the name of our alias in the future.
  4. Removed lots of extraneous files in the /luci-static directory.

To test:

  1. on the create app page, and mouse hover over the default icons
  2. choose one of the icons, and submit the app. make sure it shows up correctly on the listing.
  3. Edit the app, and change the icon to be an external image on the internet. Make sure it shows up correctly on the listing page (might need to get splashed so it allows external requests).

dismantl included the following code: https://github.com/opentechinstitute/luci-commotion-apps/pull/40/commits