opentechinstitute / luci-commotion

Commotion configuration pages for the LuCI web interface
GNU General Public License v3.0
11 stars 17 forks source link

[CLOSED] fix error displays on apps form; improve connection checking #379

Closed oti-tech closed 10 years ago

oti-tech commented 10 years ago

Issue by dismantl Saturday Dec 28, 2013 at 17:13 GMT Originally opened as https://github.com/opentechinstitute/luci-commotion-apps/pull/61


to test:

1) add app with a non-working URL. Upon submit, there should only be an error icon and error message below the URL field, instead of an error icon below every field. 2) on your machine, make sure nothing is listening on port 80 or port 443. Then run sudo nc -l -p 443 on your host machine. Then add an app with the URL https://<your client ip address> (substituting your ip address). The submission should succeed.


dismantl included the following code: https://github.com/opentechinstitute/luci-commotion-apps/pull/61/commits

oti-tech commented 10 years ago

Comment by areynold Saturday Dec 28, 2013 at 18:00 GMT


Works as described