opentechinstitute / luci-commotion

Commotion configuration pages for the LuCI web interface
GNU General Public License v3.0
11 stars 17 forks source link

Slightly refactor 'Additional Network Interfaces' page. #461

Closed jheretic closed 9 years ago

jheretic commented 9 years ago

This is a refactoring of the 'Additional Network Interfaces' page in the basic menu. It allows a user to control the gateway ethernet port's DHCP settings, as well as optionally provide a static IP configuration. It also controls whether a present gateway is advertised to the rest of the mesh, and exposes the ability to mesh over ethernet in two circumstances:

We don't provide it in circumstances where there is or may be an HNA client network on the ethernet interface, because OLSR does not permit the same interface to be both mesh and an HNA. There are edge cases that aren't covered, but trying to support them would both take significant revisions and result in potentially unexpected behavior.

To test:

Partially addresses https://github.com/opentechinstitute/luci-commotion/issues/209, and makes the process mentioned in https://github.com/opentechinstitute/luci-commotion/issues/64 largely unnecessary.

dismantl commented 9 years ago

Does this allow clients from different mesh segments (i.e. wireless versus wired) to communicate to each other? I thought firewall rule changes were needed for that.

jheretic commented 9 years ago

That is a different issue. This is just expanding the capabilities of the interface to additional use cases.