search

opentelecoms-org / jscommunicator

http://jscommunicator.org
88 stars 48 forks source link

Merge - bit of last minute stuff #40

Closed jlouback closed 10 years ago

jlouback commented 10 years ago

I deleted all third party code as it can be downloaded with the script

dpocock commented 10 years ago

I've merged these changes, please just do the remaining things as an extra pull request so I can merge them too.

jlouback commented 10 years ago

Hi Daniel,

I made a last pull request https://github.com/opentelecoms-org/jscommunicator/pull/44 with all the changes you requested. I added one more thing which was just not do anything if there are 6 chat tabs open and the user tries making a new tab. I will have to make explanatory messages and etc but I think we are good to go. I feel good about the code. I made a pull request for rtc.debian.org as well reflecting changes in JSComm.js and including font-awesome in the repo.

There are a lot of things I want to keep doing, so maybe after deb conf (during which i hope to get feedback) I'll make a list of 'future work' that I'll be doing post GSoC.

I've been somewhat ill these last few days (I'm so glad we haven't video called, I look like the devil). I'm going to try to sleep so I'll be AWOL for an hour or so. I'll check my email as soon as I wake up (if I do sleep), and if there's more to do I'll get to it.

2014-08-15 5:36 GMT-03:00 Daniel Pocock notifications@github.com:

I've merged these changes, please just do the remaining things as an extra pull request so I can merge them too.

— Reply to this email directly or view it on GitHub https://github.com/opentelecoms-org/jscommunicator/pull/40#issuecomment-52285474 .