search

opentelecoms-org / jscommunicator

http://jscommunicator.org
88 stars 48 forks source link

Last changes #44

Closed jlouback closed 10 years ago

jlouback commented 10 years ago

AUTHORS in order of contribution + homepage, get jssip from freebox.net in script (tested), font-awesome code in repo (not just one file btw), limited chat tabs to 6 (should have error message later on)

dpocock commented 10 years ago

It turns out that Font Awesome is available as a Debian package:

https://packages.qa.debian.org/f/fonts-font-awesome.html

so you can include it in the code_grab script but there is no need to include a copy of it in the repository.

Download link for the Debian package if you want to install it on your own machine: https://packages.debian.org/wheezy-backports/all/fonts-font-awesome/download

For the debrtc.org site, I installed the package on thd019, you can symlink:

ln -s /usr/share/fonts-font-awesome/css/font-awesome.min.css .

into the www directory.

I should have checked this earlier - can you please delete the font-awesome files from the pull request before I merge it.

jlouback commented 10 years ago

Hi Daniel

On the code_grab script, should I wget the package then sudo dpkg install it? As it's not a single file I am unsure

2014-08-15 11:39 GMT-03:00 Daniel Pocock notifications@github.com:

It turns out that Font Awesome is available as a Debian package:

https://packages.qa.debian.org/f/fonts-font-awesome.html

so you can include it in the code_grab script but there is no need to include a copy of it in the repository.

Download link for the Debian package if you want to install it on your own machine:

https://packages.debian.org/wheezy-backports/all/fonts-font-awesome/download

For the debrtc.org site, I installed the package on thd019, you can symlink:

ln -s /usr/share/fonts-font-awesome/css/font-awesome.min.css .

into the www directory.

I should have checked this earlier - can you please delete the font-awesome files from the pull request before I merge it.

— Reply to this email directly or view it on GitHub https://github.com/opentelecoms-org/jscommunicator/pull/44#issuecomment-52312921 .

dpocock commented 10 years ago

No, you can just wget the min.css file from the Font Awesome web site

jlouback commented 10 years ago

But just the .css isn't enough. Need other files too. Is it ok to wget the entire directory and contents?

2014-08-15 12:44 GMT-03:00 Daniel Pocock notifications@github.com:

No, you can just wget the min.css file from the Font Awesome web site

— Reply to this email directly or view it on GitHub https://github.com/opentelecoms-org/jscommunicator/pull/44#issuecomment-52321084 .

jlouback commented 10 years ago

Ok so I removed font-awesome, I included font-awesome in the code_grabber script, I only pick out whats needed (min.css and the font files). Good to go