search

opentelecoms-org / lumicall

SIP and ENUM dialer for Android with ZRTP/SRTP encryption, SIP over TLS, ICE/TURN for NAT, G.729 and many other features
http://www.lumicall.org
Other
144 stars 88 forks source link

Add PUBLISH Support #42

Closed pranavjain closed 8 years ago

pranavjain commented 8 years ago

Changes pending in PublishAgent.java

dpocock commented 8 years ago

@saghul what do you think of this latest revision? It is much easier to read.

pranavjain commented 8 years ago

I have updated all the files. Please check @saghul @dpocock

saghul commented 8 years ago

Left some minor comments, other than that it LGTM.

pranavjain commented 8 years ago

@saghul @dpocock I have done all the suggested changes. Please review.

saghul commented 8 years ago

LGTM with a couple of style nits and a question.

pranavjain commented 8 years ago

@saghul @dpocock Done all the changes!

saghul commented 8 years ago

Final LGTM, good work @pranavjain!

dpocock commented 8 years ago

@pranavjain why did you remove the try/ catch block and md = MessageDigest.getInstance("MD5"); as part of your last commit? Without that, it crashes the app.

dpocock commented 8 years ago

@pranavjain @saghul the username is not always a full SIP URI and for some accounts I see it setting From and To incorrectly. Please look at the target_url parameter in RegisterAgent.java, please add the same parameter to the PublishAgent constructor and use it in the necessary places

dpocock commented 8 years ago

I also notice that it is sending multiple PUBLISH requests to the same account very quickly at startup. Please look at how to avoid duplicate PUBLISH requests. Look at how RegisterAction keeps track of its state (UNREGISTERED / REGISTERING / REGISTERED / DEREGISTERING). You could do similar state with an enum type, in this case the enum could be part of the same source file / class.