search

opentelekomcloud / python-otcextensions

Extension of the OpenStackSDK && OpenStackClient with OpenTelekomCloud services
https://docs.otc-service.com/python-otcextensions
Apache License 2.0
24 stars 26 forks source link

vip_network_id non-existing parameter for elbv2 #227

Closed kucerakk closed 2 years ago

kucerakk commented 3 years ago

The following mapping seems to be wrong in https://github.com/opentelekomcloud/python-otcextensions/blob/master/otcextensions/sdk/elb/v2/load_balancer.py

 #: VIP netowrk ID
 vip_network_id = resource.Body('vip_network_id')

According the documentation https://docs.otc.t-systems.com/elb/doc/download/pdf/elb-api.pdf this parameter does not exist in ELBv2

Due to this update the functional tests are also failing for octavia-proxy on Zuul

gtema commented 3 years ago

I doubt. This class is actually not used at all. We should clearly drop it (and maybe it causes some conflict), but the error (would be nice to see the error also) is most likely caused by trying to set this parameter while invoking the SDK/OTCE

kucerakk commented 3 years ago

the functional tests of octavia-proxy clearly fails with error when using the latest version of otcextensions: 

b'{"faultcode": "Client", "faultstring": "Validation failure: Unrecognized attribute(s) \'vip_network_id\'", "debuginfo": null}'

using older version 0.20.0 the tests passes

This parameter vip_network_id mapping was introduced in version 0.21.0

gtema commented 3 years ago

you can try locally dropping this file. I assume nothing will change

kucerakk commented 3 years ago

you are right, the error in octavia tests has nothing to do with the parameter in otcextensions, but with the latest updates in the octavia_proxy code...going to make an issue there...

regardless of the error in octavia, I believe this parameter vip_network_id should not be in elbv2

and btw the error in octavia comes directly from neutron:

RESP BODY: {"NeutronError": {"detail": "", "type": "HTTPBadRequest", "message": "Unrecognized attribute(s) 'vip_network_id'"}}
gtema commented 3 years ago

we are not really overriding octavia resources that we use for v2. Generally octavia-proxy should not even try passing vip_network_id. You get the error cause something tries to initialize it. If this does not work perhaps we need to do same as with v3 and reimplement it on our side

anton-sidelnikov commented 2 years ago

fixed in octavia-proxy