search

opentelekomcloud / python-otcextensions

Extension of the OpenStackSDK && OpenStackClient with OpenTelekomCloud services
https://docs.otc-service.com/python-otcextensions
Apache License 2.0
24 stars 23 forks source link

Some logical error fixes in server.py and backup.py #369

Closed hlange4 closed 8 months ago

hlange4 commented 8 months ago

server.py: It appears that the session parameter is being overwritten in both the add_tag and remove_tag methods, therfore I would remove the lines that overwrites the session variable

test_server.py: The unit test failures are due to the tests expecting that self.sot._connection.ecs.post is called, but after our refactoring, the provided session's post method is the one being called instead.

backup.py: Don't overwrite the params argument, but merge the needed params (now declared as request_params) passed as an argument.

anton-sidelnikov commented 8 months ago

Agree, good points

otc-zuul[bot] commented 8 months ago

Build succeeded. https://zuul.otc-service.com/t/eco/buildset/f4ccc171d79145c59788bd6502295b06

:heavy_check_mark: otc-tox-docs SUCCESS in 13m 03s :heavy_check_mark: otc-tox-py38 SUCCESS in 4m 17s :heavy_check_mark: otc-tox-pep8 SUCCESS in 7m 10s :heavy_check_mark: tox-functional-eu-de SUCCESS in 10m 29s :heavy_check_mark: otce-upload-image SUCCESS in 3m 20s