search

opentelekomcloud / vault-plugin-secrets-openstack

Create OpenStack tokens using HashiCorp Vault
Apache License 2.0
23 stars 6 forks source link

Static roles: detailed openstack domain/project settings + error messages fix #126

Closed artem-lifshits closed 1 year ago

artem-lifshits commented 1 year ago

Added user_domain_id/name and project_domain_id/name parameters for detailed static roles management. Several error messages fixed.

Acceptance tests

vault-plugin-secrets-openstack % make functional Running acceptance tests... === RUN TestPlugin === RUN TestPlugin/TestCloudLifecycle === RUN TestPlugin/TestCloudLifecycle/WriteCloud === RUN TestPlugin/TestCloudLifecycle/ReadCloud === RUN TestPlugin/TestCloudLifecycle/ListClouds === RUN TestPlugin/TestCloudLifecycle/ListClouds/method-LIST === PAUSE TestPlugin/TestCloudLifecycle/ListClouds/method-LIST === RUN TestPlugin/TestCloudLifecycle/ListClouds/method-GET === PAUSE TestPlugin/TestCloudLifecycle/ListClouds/method-GET === CONT TestPlugin/TestCloudLifecycle/ListClouds/method-LIST === CONT TestPlugin/TestCloudLifecycle/ListClouds/method-GET === RUN TestPlugin/TestCloudLifecycle/DeleteCloud === RUN TestPlugin/TestCredsLifecycle === RUN TestPlugin/TestCredsLifecycle/user_domain_id_token === RUN TestPlugin/TestCredsLifecycle/root_token === RUN TestPlugin/TestCredsLifecycle/user_token === RUN TestPlugin/TestCredsLifecycle/user_password === RUN TestPlugin/TestInfo info_test.go:42: Error Trace: info_test.go:42 Error: Should NOT be empty, but was &{ } Test: TestPlugin/TestInfo === RUN TestPlugin/TestRoleLifecycle === RUN TestPlugin/TestRoleLifecycle/WriteRole === RUN TestPlugin/TestRoleLifecycle/ReadRole === RUN TestPlugin/TestRoleLifecycle/ListRoles === RUN TestPlugin/TestRoleLifecycle/ListRoles/method-LIST === PAUSE TestPlugin/TestRoleLifecycle/ListRoles/method-LIST === RUN TestPlugin/TestRoleLifecycle/ListRoles/method-GET === PAUSE TestPlugin/TestRoleLifecycle/ListRoles/method-GET === CONT TestPlugin/TestRoleLifecycle/ListRoles/method-LIST === CONT TestPlugin/TestRoleLifecycle/ListRoles/method-GET === RUN TestPlugin/TestRoleLifecycle/DeleteRole === RUN TestPlugin/TestRootRotate rotate_test.go:65: Cloud with name default1 was created rotate_test.go:68: Cloud with name 4bju was created plugin_test.go:337: Cloud with name 4bju has been removed plugin_test.go:337: Cloud with name default1 has been removed === RUN TestPlugin/TestStaticCredsLifecycle === RUN TestPlugin/TestStaticCredsLifecycle/user_password === RUN TestPlugin/TestStaticCredsLifecycle/user_token_project_id === RUN TestPlugin/TestStaticCredsLifecycle/user_token_project_name === RUN TestPlugin/TestStaticCredsLifecycle/user_domain_id_token === RUN TestPlugin/TestStaticRoleLifecycle === RUN TestPlugin/TestStaticRoleLifecycle/WriteRole === RUN TestPlugin/TestStaticRoleLifecycle/ReadRole === RUN TestPlugin/TestStaticRoleLifecycle/ListRoles === RUN TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST === PAUSE TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST === RUN TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET === PAUSE TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET === CONT TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST === CONT TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET === RUN TestPlugin/TestStaticRoleLifecycle/DeleteRole --- FAIL: TestPlugin (32.71s) --- PASS: TestPlugin/TestCloudLifecycle (0.04s) --- PASS: TestPlugin/TestCloudLifecycle/WriteCloud (0.04s) --- PASS: TestPlugin/TestCloudLifecycle/ReadCloud (0.00s) --- PASS: TestPlugin/TestCloudLifecycle/ListClouds (0.00s) --- PASS: TestPlugin/TestCloudLifecycle/ListClouds/method-LIST (0.00s) --- PASS: TestPlugin/TestCloudLifecycle/ListClouds/method-GET (0.00s) --- PASS: TestPlugin/TestCloudLifecycle/DeleteCloud (0.00s) --- PASS: TestPlugin/TestCredsLifecycle (7.99s) --- PASS: TestPlugin/TestCredsLifecycle/user_domain_id_token (2.96s) --- PASS: TestPlugin/TestCredsLifecycle/root_token (0.83s) --- PASS: TestPlugin/TestCredsLifecycle/user_token (2.38s) --- PASS: TestPlugin/TestCredsLifecycle/user_password (0.97s) --- FAIL: TestPlugin/TestInfo (0.00s) --- PASS: TestPlugin/TestRoleLifecycle (0.61s) --- PASS: TestPlugin/TestRoleLifecycle/WriteRole (0.59s) --- PASS: TestPlugin/TestRoleLifecycle/ReadRole (0.00s) --- PASS: TestPlugin/TestRoleLifecycle/ListRoles (0.00s) --- PASS: TestPlugin/TestRoleLifecycle/ListRoles/method-GET (0.00s) --- PASS: TestPlugin/TestRoleLifecycle/ListRoles/method-LIST (0.00s) --- PASS: TestPlugin/TestRoleLifecycle/DeleteRole (0.00s) --- PASS: TestPlugin/TestRootRotate (4.72s) --- PASS: TestPlugin/TestStaticCredsLifecycle (16.24s) --- PASS: TestPlugin/TestStaticCredsLifecycle/user_password (3.38s) --- PASS: TestPlugin/TestStaticCredsLifecycle/user_token_project_id (4.00s) --- PASS: TestPlugin/TestStaticCredsLifecycle/user_token_project_name (3.91s) --- PASS: TestPlugin/TestStaticCredsLifecycle/user_domain_id_token (3.92s) --- PASS: TestPlugin/TestStaticRoleLifecycle (2.96s) --- PASS: TestPlugin/TestStaticRoleLifecycle/WriteRole (1.05s) --- PASS: TestPlugin/TestStaticRoleLifecycle/ReadRole (0.00s) --- PASS: TestPlugin/TestStaticRoleLifecycle/ListRoles (0.00s) --- PASS: TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST (0.00s) --- PASS: TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET (0.00s) --- PASS: TestPlugin/TestStaticRoleLifecycle/DeleteRole (0.00s) FAIL FAIL github.com/opentelekomcloud/vault-plugin-secrets-openstack/acceptance 33.138s FAIL make: *** [functional] Error 1

artem-lifshits commented 1 year ago

Recheck

otc-zuul[bot] commented 1 year ago

Build failed. https://zuul.otc-service.com/t/eco/buildset/ab88070524c14bc395d5c5e308f7c8cf

:heavy_check_mark: build-sphinx-docs SUCCESS in 3m 28s :heavy_check_mark: otc-golangci-lint SUCCESS in 1m 58s :heavy_check_mark: golang-make-vet SUCCESS in 2m 00s :x: golang-make-test FAILURE in 1m 53s :heavy_check_mark: goreleaser-build SUCCESS in 4m 22s

otc-zuul[bot] commented 1 year ago

Build succeeded. https://zuul.otc-service.com/t/eco/buildset/0cb7ed3444094413a6f1de2052afff96

:heavy_check_mark: build-sphinx-docs SUCCESS in 3m 22s :heavy_check_mark: otc-golangci-lint SUCCESS in 2m 11s :heavy_check_mark: golang-make-vet SUCCESS in 2m 13s :heavy_check_mark: golang-make-test SUCCESS in 2m 13s :heavy_check_mark: goreleaser-build SUCCESS in 4m 14s