search

opentensor / bittensor

Internet-scale Neural Networks
https://www.bittensor.com/
MIT License
818 stars 276 forks source link

Fix incorrent import order of `bittensor/commands/utils.py:defaults` a potential import error #2029

Closed RomanCh-OT closed 1 week ago

RomanCh-OT commented 1 week ago

Approved. Just make absolutely sure Raj is aware of the change of defaults for release, because this is breaking.

Could you please explain why this is breaking? I didn't change defaults at all, just moved to logically correct place. This is a local defaults for a sub-package of commands, not related to the defaults in the bittensor root ( init .py). Am I missing something?

thewhaleking commented 1 week ago

Approved. Just make absolutely sure Raj is aware of the change of defaults for release, because this is breaking.

Could you please explain why this is breaking? I didn't change defaults at all, just moved to logically correct place. This is a local defaults for a sub-package of commands, not related to the defaults in the bittensor root ( init .py). Am I missing something?

It's breaking because you're moving its location.

RomanCh-OT commented 1 week ago

Approved. Just make absolutely sure Raj is aware of the change of defaults for release, because this is breaking.

Could you please explain why this is breaking? I didn't change defaults at all, just moved to logically correct place. This is a local defaults for a sub-package of commands, not related to the defaults in the bittensor root ( init .py). Am I missing something?

It's breaking because you're moving its location.

Raj is informed