Async tests fix for `tests/integration_tests` directory + e2e tests commented

opentensor / bittensor

Internet-scale Neural Networks

https://www.bittensor.com/

MIT License

816 stars 274 forks source link

Async tests fix for `tests/integration_tests` directory + e2e tests commented #2042

Closed RomanCh-OT closed 2 weeks ago

RomanCh-OT commented 2 weeks ago

Async tests fix for tests/integration_tests directory

RomanCh-OT commented 2 weeks ago

None of these coroutine tests appear to actually run. You can test it by adding self.assertEqual(1, 2) into any of them, and running the suite, and they will still pass.

You defenately right! We have to use unittest.IsolatedAsyncioTestCase instead of unittest.TestCase for making correct async tests based on unittest lib.

RomanCh-OT commented 2 weeks ago

Additional context:

real fix tests/integration_tests/test_subtensor_integration.py with async unittest.
commented blocking test in tests/integration_tests/test_cli.py because those tests based on sync cli.py module. Will be fixed later.
test_cli.py and e2e tests marked commented until commands and cli migrated.
TODO: fix after commands and cli are async migrated