opentensor / bittensor

Internet-scale Neural Networks
https://www.bittensor.com/
MIT License
918 stars 318 forks source link

fix regression where COLD_PW can no longer be passed with env vars co… #2308

Closed mjurbanski-reef closed 3 weeks ago

mjurbanski-reef commented 2 months ago

Bug

-

Description of the Change

Apparently, in the context of python it was possible to set a env var with hyphen in it. Which makes change introduced by https://github.com/opentensor/bittensor/pull/1949 a breaking one which is not acceptable as it was introduced in minor version of bittensor, hence breaking semver contract.

This PR makes sure we support proper env variable names, while also not breaking users that used hyphens within the env var name.

See https://discord.com/channels/1120750674595024897/1242999357436071956/1284309400751964271 for more context.

Alternate Designs

Ignore the regression, but that conflicts with semver versioning and further discourages keeping with the latest bittensor version.

Possible Drawbacks

Not forcing users to migrate asap.

Verification Process

Unit test

Release Notes

mjurbanski-reef commented 3 weeks ago

no longer relevant after refactor