opentensor / subtensor

Bittensor Blockchain Layer
The Unlicense
145 stars 149 forks source link

fix: chainspec irregularities #493

Closed orriin closed 3 months ago

orriin commented 4 months ago

Closes https://github.com/opentensor/subtensor/issues/489

TODO

prop-opentensor commented 4 months ago

bootnodes:

finney: /dns/bootnode.finney.chain.opentensor.ai/tcp/30333/ws/p2p/12D3KooWRwbMb85RWnT8DSXSYMWQtuDwh4LJzndoRrTDotTR5gDC testnet: /dns/bootnode.test.chain.opentensor.ai/tcp/30333/p2p/12D3KooWPM4mLcKJGtyVtkggqdG84zWrd7Rij6PGQDoijh1X86Vr

fyi: raw_testspec.json is currently in use on devnet validators - since we plan to replace devnet with the testnet mirror, imo this can still be removed

orriin commented 4 months ago

fyi: raw_testspec.json is currently in use on devnet validators - since we plan to replace devnet with the testnet mirror, imo this can still be removed

Cool, yeah I'm removing all of finney_plain_spec.json, raw_spec.json, raw_testspec.json, they seem to just be duplicates.

birkskyum commented 4 months ago

related - i just noticed that the mainnet spec files was also used for people wanting to start at testnet docker container, but it might be obsoleted if those spec files are now deleted

Also, these raw_spec.json is mentioned in docs all over the place, which would be good to have synced with this change

birkskyum commented 4 months ago

out of curiosity, what is the difference between raw_spec and plain_spec?

orriin commented 4 months ago

out of curiosity, what is the difference between raw_spec and plain_spec?

See the 'Raw chain specifications' section at these docs https://docs.substrate.io/build/chain-spec/

birkskyum commented 4 months ago

@orriin , can you update the docker-compose and scripts/run/subtensor.sh too in a way that aligns with this change? they use the raw_spec.json / raw_testspec.json that are removed in this PR and will thus break.

Also, running a lite node on testchain with docker breaks because the subtensor.sh doesn't conditionally use a spec for the testnet when setting the test flag, which I resolved in ( #329 ) , but since this PR obsoletes that work it would be reasonable to include the fix here with the name of the new main/test spec files.

rajkaramchedu commented 3 months ago

We don't use the word "finney" in the published docs. We use "mainnet" or "testnet" or "devnet" or "local". Given this, for clarifying what's what in my docs, are the below two statements accurate?

Thanks

orriin commented 3 months ago

We don't use the word "finney" in the published docs. We use "mainnet" or "testnet" or "devnet" or "local". Given this, for clarifying what's what in my docs, are the below two statements accurate?

  • The raw_spec_finney.json spec is for mainnet.
  • The raw_spec_testfinney.json spec is for testnet.

Thanks

This is correct :)