Previously, the can_commit function checked to see if a whole commit_reveal_weights_interval has passed before being allowed to commit weights again. Instead, we should keep this logic for when we can reveal_weights (as is intended), but the neuron should be able to commit weights multiple times within a single commit_reveal_weights_interval according to the weights_rate_limit hyperparameter. If not, the weights_rate_limit is essentually useless because the can_commit function overrides the weights_rate_limit.
Furthermore, it introduces an edge case where if commit_reveal_weights_interval if > activity_cutoff, all weights go away and the network stalls because neurons are now setting weights > once per activity_cutoff. This PR fixes this too.
Type of Change
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please describe):
Checklist
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Screenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.
Description
Previously, the can_commit function checked to see if a whole commit_reveal_weights_interval has passed before being allowed to commit weights again. Instead, we should keep this logic for when we can reveal_weights (as is intended), but the neuron should be able to commit weights multiple times within a single commit_reveal_weights_interval according to the weights_rate_limit hyperparameter. If not, the weights_rate_limit is essentually useless because the can_commit function overrides the weights_rate_limit.
Furthermore, it introduces an edge case where if commit_reveal_weights_interval if > activity_cutoff, all weights go away and the network stalls because neurons are now setting weights > once per activity_cutoff. This PR fixes this too.
Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.