This PR fixes issues related to NeuronInfoApi inconsistencies. Currently NeuronInfoLite returns alpha, while NeuronInfo returns stake weight. This issue was discussed with @camfairchild and it was considered to use stake weights for stakes in NeuronInfo/NeuronInfoLite.
No changes needed anymore related to NeuronInfoApi.
Also, during debugging, other issues were discovered (comment in #925 and related issue). This PR fixes these issues by changing initial TAO and Alpha for subnets to 1_000_000_000.
Initially the work were done on fix/neuron-info-lite-stake, but that branch were made from feat/rao-devnet-ready, so this branch just applies the changes to the new feat/rao-devnet-ready-2 branch.
Related Issue(s)
Closes #879, #925, #969
Type of Change
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please describe):
Breaking Changes
As bittensor wallet previously relied on wrong data and for them the issue seemed like API returned stake vs alpha, they should adapt their code to use stake weights instead.
Checklist
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[X] I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
This PR fixes issues related to
NeuronInfoApiinconsistencies. CurrentlyNeuronInfoLitereturns alpha, whileNeuronInforeturns stake weight. This issue was discussed with @camfairchild and it was considered to use stake weights for stakes inNeuronInfo/NeuronInfoLite.The issue was discovered during debugging: https://github.com/opentensor/subtensor/issues/879
No changes needed anymore related to
NeuronInfoApi.Also, during debugging, other issues were discovered (comment in #925 and related issue). This PR fixes these issues by changing initial TAO and Alpha for subnets to
1_000_000_000.Initially the work were done on
fix/neuron-info-lite-stake, but that branch were made fromfeat/rao-devnet-ready, so this branch just applies the changes to the newfeat/rao-devnet-ready-2branch.Related Issue(s)
Type of Change
Breaking Changes
As bittensor wallet previously relied on wrong data and for them the issue seemed like API returned stake vs alpha, they should adapt their code to use stake weights instead.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly