search

opentensor / validators

Repository for bittensor validators
https://www.bittensor.com/
MIT License
14 stars 9 forks source link

- Stop vali from forwarding requests if dereg #117

Open Inquinim opened 1 year ago

Inquinim commented 1 year ago

There are a lot of validators that deregister from the network but continue forwarding requests which floods the network. A simple metagraph lookup should solve the issue.

@ifrit98 @shibshib

p-ferreira commented 1 year ago

This change adds a component to put the validator to sleep in case it gets deregistered, which it will continue until the validator gets registered again, skipping the processing steps while not registered.

It seems ok for me, unless we want to explicitly stop the validator operation whenever it gets deregistered. @Eugene-hu @opentaco @isabella618033 @steffencruz any thoughts about merging this change?

Eugene-hu commented 1 year ago

This change adds a component to put the validator to sleep in case it gets deregistered, which it will continue until the validator gets registered again, skipping the processing steps while not registered.

It seems ok for me, unless we want to explicitly stop the validator operation whenever it gets deregistered. @Eugene-hu @opentaco @isabella618033 @steffencruz any thoughts about merging this change?

I agree, I think if a validator gets deregistered, it should instead break and stop the script rather than sleep forever

steffencruz commented 1 year ago

I agree. Breaking is better