search

openthc / ccrs

Tracking for the WSLCB CCRS
https://lcb.wa.gov/ccrs
MIT License
4 stars 0 forks source link

Error Report Scrambles Data #31

Open djbusby opened 2 years ago

djbusby commented 2 years ago

Some of the error reports scramble the date fields, switching to ISO from the LCB's preferred US-style (it should remain as US-mdy style).

Also, the column order in the error files is scrambled, so that the response file has the fields in a different order.

Both of these issues make it hard to hash-map the data to match uploads to source data.

djbusby commented 1 year ago

Another case we've uploaded

LicenseNumber,Area,IsQuarantine,ExternalIdentifier,CreatedBy,CreatedDate,UpdatedBy,UpdatedDate,Operation
-canary-,SECTION UPLOAD 01GX7MQBXCV218ZG9TESDH4Z91,FALSE,-canary-,-canary-,04/05/2023,-canary-,04/05/2023,UPDATE
01CAV126M8H6G3PZVS3ZDC3BRA,OPENTHC SECTION PING,FALSE,OPENTHC SECTION PING,-system-,04/05/2023,-system-,04/05/2023,DELETE

And we get back:

LicenseNumber,Area,IsQuarantine,ExternalIdentifier,CreatedBy,CreatedDate,UpdatedBy,UpdatedDate,Operation,ErrorMessage
-canary-,SECTION UPLOAD 01GX7MQBXCV218ZG9TESDH4Z91,F,-canary-,-canary-,04/05/2023,-canary-,04/05/2023,UPDATE,Integrator is not authorized to update licensee: ExternalIdentifier not found: LicenseNumber must be numeric: Invalid LicenseeID
01CAV126M8,OPENTHC SECTION PING,F,OPENTHC SECTION PING,-system-,04/05/2023,-system-,04/05/2023,DELETE,Integrator is not authorized to update licensee: ExternalIdentifier not found: LicenseNumber must be numeric: Invalid LicenseeID

Notice that the crazy long LicenseNumber was truncated and also the IsQuarantine field is truncated as well.