openthc / ccrs

Tracking for the WSLCB CCRS
https://lcb.wa.gov/ccrs
MIT License
4 stars 0 forks source link

CSVs should be RFC4180 Compliant #35

Open djbusby opened 2 years ago

djbusby commented 2 years ago

This was reported ages ago (at least Dec 1st, if not earlier) The CSV files that the LCB accepts are not compliant with RFC4180 -- so this means, no quoted fields and no embedded commas in field values (and likely a host of other bugs)

https://datatracker.ietf.org/doc/html/rfc4180 Also, for notes: https://datatracker.ietf.org/doc/html/rfc7111

djbusby commented 2 years ago

Adding onto this; previously many files were submitted using UNIX style line endings. Just recently that switched and now their system REQUIRES a CRLF (Windows) style line-ending.

We have looked at your files and found that all your line endings are not Microsoft Windows .CSV line endings (CRLF). When files are originated on a Unix based system, or the file is generated programmatically, the correct line endings may not have been specified correctly. Please save your files as a Windows .CSV file type, and resubmit your files.

djbusby commented 2 years ago

The LCB will NOT fix this issue