openthc / ccrs

Tracking for the WSLCB CCRS
https://lcb.wa.gov/ccrs
MIT License
4 stars 0 forks source link

Manifest.csv Fail with "has not been processed" #54

Open djbusby opened 1 year ago

djbusby commented 1 year ago

Every Manifest file we've tried has given this error. We've tried dozens of different files. We've iterated a bunch of different options to no change. It's IR68547 with LCB. Confirmed this is happening to other vendors as well. 12 calendar days to launch.

djbusby commented 1 year ago

Says my ticket was updated "Tue, Dec 27, 2022 at 9:44 AM" but the notification email is empty.

djbusby commented 1 year ago

At Tue, Dec 27, 2022 at 11:20 AM Olympia time:

David,

We identified and updated a configuration affecting your account when introducing the Manifest file. Thank you for bringing the vague error messages to our attention. These files may be resubmitted and we’ve taken note of the setting for production deployment.

djbusby commented 1 year ago

Now however, when using perfectly valid email addresses, and leveraging UAE (eg: user+CODE@example.com) the system is rejecting them. Or perhaps it's because the emails are not on some blessed list. The error messages are simply 'Invalid OriginLicenseeEmailAddress' and 'Invalid DestinationLicenseeEmailAddress'.

djbusby commented 1 year ago

Ok, I've tried again with a simpler email address and can confirm that the system is not correctly validating email addresses. That '+' character is blocking. This is an incorrect validation of email, see https://en.wikipedia.org/wiki/Email_address#Local-part -- or any of the email RFCs.

djbusby commented 1 year ago

See also: https://people.cs.rutgers.edu/~watrous/plus-signs-in-email-addresses.html

djbusby commented 1 year ago

Worked through a few more expected errors and corrected them. And now it's back to "has not been processed" message.

djbusby commented 1 year ago

I've done yet another upload and check this out...I'm leaving the UpdateBy field empty but the response/error CSV from y'all has it partially populated. Where did that phantom data come from?

djbusby commented 1 year ago

Oh my, so that file that kept failing....now when I upload it -- even tho it has failed every time -- gives the error "Duplicate ExternalManifestIdentifier".How can it be a duplicate if all the previous uploads had failed?

djbusby commented 1 year ago

Oh, and then I got a duplicate email from the system about the exact same upload. It looks like the system sends the error-notice twice?

But also, after enough fiddling; we've managed to get one in there.

Urgently need LCB to follow email standards for the Origin and Destination addresses.

tomwilsond1 commented 1 year ago

We are stuck at the

"has not been processed" message as well now.

Submitted bug report to LCB, have you gotten it to go through yet to receive a PDF?

djbusby commented 1 year ago

We have had ONE successful file; then submitted it again and got the expected "duplicate" error message. We made some very minor changes to the file (just manifest ID) and it's back to "has not been processed" message. Have opened a new ticket. IR68950